Rachelint commented on PR #15591: URL: https://github.com/apache/datafusion/pull/15591#issuecomment-2785561617
> Hi @Rachelint I think I have a alternative proposal that seems relatively easy to implement. I'll share it with you once I have some time to validate the design (probably this evening). Really thanks. This design in pr indeed introduces quite a few code changes... I tried to not modify anythings about `GroupAccumulator` firstly: - Only implement the `blocked logic` in `GroupValues` - Then we reorder the `input batch` according to their `block index` got from `GroupValues` - Apply `input batch` to related `GroupAccumulator` using slice - And when we found the `new block is needed`, create a new `GroupAccumulator` But I found this way will introduce too many extra cost... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
