logan-keede commented on issue #13814: URL: https://github.com/apache/datafusion/issues/13814#issuecomment-2786971990
>FYI @logan-keede -- maybe we can see how much this helps the build speed _Originally posted by @alamb in https://github.com/apache/datafusion/issues/15625#issuecomment-2786005044_ It actually does not seem to have much impact on CI. after some digging, or rather building with different version of rustc I observed that build time for 1.85.1 and 1.86.0 are similar but better than that of 1.84.1(the version I was using during initial profiling). for reference, datafusion-catalog takes ~50 sec if rustc>1.85 but >60 sec if rustc ==1.84.1 on my laptop TLDR: Improvements I observed were actually introduced in 1.85 and we were already benefiting from them. Sorry for the false positive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
