Blizzara commented on code in PR #15634: URL: https://github.com/apache/datafusion/pull/15634#discussion_r2033110193
########## datafusion/substrait/tests/cases/roundtrip_logical_plan.rs: ########## @@ -1061,7 +1061,7 @@ async fn roundtrip_literal_list() -> Result<()> { async fn roundtrip_literal_struct() -> Result<()> { let plan = generate_plan_from_sql( "SELECT STRUCT(1, true, CAST(NULL AS STRING)) FROM data", - false, + true, Review Comment: unrelated, but it was passing with true so why not have that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org