timsaucer commented on PR #15646: URL: https://github.com/apache/datafusion/pull/15646#issuecomment-2789600400
Some of the concerns I have: - Canonical extension types in `arrow-rs` have an implementation of ` TryFrom<&Field>` which lends towards the original Issue's suggestion of passing `Field` rather than just the metadata. - I need to add unit tests to make sure other operations don't throw away the metadata. I don't know if there is a one size fits all solution for which should an which should not pass through metadata. For example, `alias` should definitely keep the metadata IMO but what about functions that take two inputs? And all of the other single input functions - it's not clear if we need to handle this one a case by case basis or not. - If we do switch over to `Field` then it isn't immediately obvious to me what the `name` should be for the field. I need to investigate this a little more because there might already be a solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
