alamb commented on code in PR #15654:
URL: https://github.com/apache/datafusion/pull/15654#discussion_r2035149730
##########
datafusion/physical-plan/src/spill/spill_manager.rs:
##########
@@ -126,14 +125,11 @@ impl SpillManager {
&self,
spill_file_path: RefCountedTempFile,
) -> Result<SendableRecordBatchStream> {
- let mut builder = RecordBatchReceiverStream::builder(
+ let stream = Box::pin(SpillReaderStream::new(
Arc::clone(&self.schema),
- self.batch_read_buffer_capacity,
- );
- let sender = builder.tx();
+ spill_file_path,
+ ));
- builder.spawn_blocking(move || read_spill(sender,
spill_file_path.path()));
Review Comment:
Is read_spill used anywhere else? It seems like this PR's approach is
strictly better and so we could entirely remove the old method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
