DerGut opened a new pull request, #15635: URL: https://github.com/apache/datafusion/pull/15635
## Which issue does this PR close? Ignores a Clippy warning identified in https://github.com/apache/datafusion/pull/15625. Note, that this warning seems to be a false positive. I've submitted an issue with the Clippy project https://github.com/rust-lang/rust-clippy/issues/14566. Ideally we'd get this fixed upstream instead of having to add this ignore directive. ## Rationale for this change As mentioned in https://github.com/apache/datafusion/pull/15625#pullrequestreview-2748351074, we get a Clippy warning ``` warning: parameter is only used in recursion --> datafusion/physical-optimizer/src/aggregate_statistics.rs:48:9 | 48 | config: &ConfigOptions, | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` | note: parameter used here --> datafusion/physical-optimizer/src/aggregate_statistics.rs:86:42 | 86 | self.optimize(child, config).map(Transformed::yes) | ^^^^^^ ... 91 | plan.map_children(|child| self.optimize(child, config).map(Transformed::yes)) | ^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion = note: `#[warn(clippy::only_used_in_recursion)]` on by default ``` when linting the `datafusion-physical-optimizer` crate: `cargo clippy -p datafusion-physical-optimizer`. ## What changes are included in this PR? No real change was possible, so I added an ignore directive. Clippy suggests to prefix the `config` parameter with an underscore but it is still used in the function body to pass it to recursive calls. Removing the parameter was also not an option because it is defined on the `PhysicalOptimizerRule` trait and other implementations use it. ## Are these changes tested? Running `cargo clippy -p datafusion-physical-optimizer` now reports no warnings. ## Are there any user-facing changes? No, no actual code change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
