mbutrovich commented on PR #1619: URL: https://github.com/apache/datafusion-comet/pull/1619#issuecomment-2783994419
Now that I think about it more: should this be a distinct config from Spark's (i.e., a Comet config like we might do with reorder_filters)? If we fallback to Spark scan are we hurting performance if this is set to false (as suggested by the tuning guide). Maybe we expect if someone is enabling the experimental reader, they should know that their workload is already capable of not falling back to Spark for scan. We can revisit these configs and defaults in the future, I suppose. For now I think this is reasonable for benchmarking the experimental readers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
