chenkovsky commented on code in PR #15603:
URL: https://github.com/apache/datafusion/pull/15603#discussion_r2030172787
##########
datafusion/physical-plan/src/stream.rs:
##########
@@ -362,6 +362,8 @@ pin_project! {
#[pin]
stream: S,
+
+ transform_schema: bool,
Review Comment:
yes, correct nullability in schema is better. I tried to fix logical plan
before.
But nullability in logical plan won't affect physical plan. it's ignored.
https://github.com/apache/datafusion/blob/dccf3778e95037f3ed8740627799e9d658943157/datafusion/core/src/physical_planner.rs#L763
in physical plan, it will recompute nullaibility from bottom to top.
https://github.com/apache/datafusion/blob/dccf3778e95037f3ed8740627799e9d658943157/datafusion/physical-plan/src/projection.rs#L85
but in this scenario, it seems that we need to pass nullability from top to
bottom.
I need more suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
