alamb commented on code in PR #15590:
URL: https://github.com/apache/datafusion/pull/15590#discussion_r2030131422
##########
datafusion/physical-plan/src/joins/mod.rs:
##########
@@ -39,6 +40,11 @@ mod join_hash_map;
#[cfg(test)]
pub mod test_utils;
+/// The on clause of the join, as vector of (left, right) columns.
Review Comment:
It might make a nicer codebase if these were real structs rather than type
defs
```rust
pub struct JoinOn {
inner: Vec<(PhysicalExprRef, PhysicalExprRef)>;
}
```
And then we could name the various accesses.
totally something for a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
