berkaysynnada commented on code in PR #15570:
URL: https://github.com/apache/datafusion/pull/15570#discussion_r2028923212
##########
datafusion/physical-plan/src/joins/cross_join.rs:
##########
@@ -189,19 +188,12 @@ impl CrossJoinExec {
/// Asynchronously collect the result of the left child
async fn load_left_input(
- left: Arc<dyn ExecutionPlan>,
- context: Arc<TaskContext>,
+ stream: SendableRecordBatchStream,
metrics: BuildProbeJoinMetrics,
reservation: MemoryReservation,
) -> Result<JoinLeftData> {
// merge all left parts into a single stream
- let left_schema = left.schema();
- let merge = if left.output_partitioning().partition_count() != 1 {
- Arc::new(CoalescePartitionsExec::new(left))
- } else {
- left
- };
- let stream = merge.execute(0, context)?;
+ let left_schema = stream.schema();
Review Comment:
dead comment above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
