2010YOUY01 commented on PR #15501: URL: https://github.com/apache/datafusion/pull/15501#issuecomment-2774917623
> In my mind the only thing remaining for this PR is to reduce the time down from 30 seconds somehow (maybe split it into multiple smaller tests that can run in parallel, for example?) I let it run for a smaller amount of time in [1b015fb](https://github.com/apache/datafusion/pull/15501/commits/1b015fb5c745851d96a78e5ba4256651a44adc81) ``` [SortQueryFuzzer] Time limit reached: 7 queries (5 random configs each) in 1 rounds successes: fuzz_cases::sort_query_fuzz::sort_query_fuzzer_runner test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 68 filtered out; finished in 5.03s ``` It will always break after 5 sec is reached, and it has executed 35 query/config combinations on my machine. Breaking it into smaller tests might help, because now the testing throughput bottleneck is verifying the result: it has to do the expensive formatting on the result set, sort the formatted result, and check equal. I think this is worth to do after this fuzzer can stably pass without discovering new issue, added this idea to the tracking issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
