Omega359 commented on code in PR #15119:
URL: https://github.com/apache/datafusion/pull/15119#discussion_r2007422753
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1632,7 +1632,7 @@ impl FunctionRegistry for SessionContext {
}
fn expr_planners(&self) -> Vec<Arc<dyn ExprPlanner>> {
- self.state.read().expr_planners()
+ self.state.read().expr_planners().to_vec()
Review Comment:
I think it's ContextProvider that uses a slice vs Vec. Bit annoying the
types are not aligned. SessionState uses `expr_planners: Vec<Arc<dyn
ExprPlanner>>,`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
