Copilot commented on code in PR #1226:
URL:
https://github.com/apache/datafusion-ballista/pull/1226#discussion_r2029326895
##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -276,10 +276,11 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerGrpc
let session_config =
session_config.update_from_key_value_pair(&session_params.settings);
+ // FIXME: this method is wrong
let ctx = self
.state
.session_manager
- .create_session(&session_config)
+ .create_session("!!! CHANGE ME !!!", &session_config)
Review Comment:
Placeholder session id '!!! CHANGE ME !!!' found; please replace it with a
proper session id or refactor the API usage to adhere to stateless session
management.
##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -276,10 +276,11 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerGrpc
let session_config =
session_config.update_from_key_value_pair(&session_params.settings);
+ // FIXME: this method is wrong
Review Comment:
The FIXME comment indicates that the current implementation is incorrect;
please implement the proper session creation/update logic or remove the comment
once resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
