Dandandan commented on code in PR #15324:
URL: https://github.com/apache/datafusion/pull/15324#discussion_r2005798767
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -752,10 +761,245 @@ impl Accumulator for DistinctCountAccumulator {
}
}
+/// GroupsAccumulator for COUNT DISTINCT operations
+#[derive(Debug)]
+pub struct DistinctCountGroupsAccumulator {
Review Comment:
Also using the `HashTable` API would probably give some further gains
https://docs.rs/hashbrown/latest/hashbrown/struct.HashTable.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
