alamb commented on code in PR #12302:
URL: https://github.com/apache/datafusion/pull/12302#discussion_r2027651936
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -154,14 +165,36 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
if self.aborted {
return Poll::Ready(None);
}
- // try to initialize the loser tree
+ // Once all partitions have set their corresponding cursors for the
loser tree,
+ // we skip the following block. Until then, this function may be
called multiple
+ // times and can return Poll::Pending if any partition returns
Poll::Pending.
if self.loser_tree.is_empty() {
- // Ensure all non-exhausted streams have a cursor from which
- // rows can be pulled
- for i in 0..self.streams.partitions() {
- if let Err(e) = ready!(self.maybe_poll_stream(cx, i)) {
- self.aborted = true;
- return Poll::Ready(Some(Err(e)));
+ let remaining_partitions = self.uninitiated_partitions.clone();
Review Comment:
This clone in particular shows up in traces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
