alamb commented on code in PR #15567:
URL: https://github.com/apache/datafusion/pull/15567#discussion_r2027613057
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+use core::panic;
Review Comment:
I haven't seen `panic` explicitly imported before (I think panic is in the
standard prelude) 🤔
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+use core::panic;
Review Comment:
```suggestion
```
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -4665,18 +4674,18 @@ Projection: person.id, person.age
}
#[test]
-fn test_prepare_statement_infer_types_from_between_predicate() {
+fn test_infer_types_from_between_predicate() {
let sql = "SELECT id, age FROM person WHERE age BETWEEN $1 AND $2";
- let expected_plan = r#"
-Projection: person.id, person.age
- Filter: person.age BETWEEN $1 AND $2
- TableScan: person
- "#
- .trim();
-
- let expected_dt = "[Int32]";
Review Comment:
it seems like this lost the datatype somehow
Maybe we can make a function that returns the plan string as well as the
logical datatype?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
