2010YOUY01 commented on issue #15406: URL: https://github.com/apache/datafusion/issues/15406#issuecomment-2764433471
> Hi, [@2010YOUY01](https://github.com/2010YOUY01). I have read and tried to understand both SortMergeJoinStream and GroupedHashAggregateStream (though I still have some uncertainties). I have some initial thoughts on organizing the structure, but I’m not sure about the right level of granularity. Perhaps we can first only reorder the fields, and put them into different groups with separators like https://github.com/apache/datafusion/blob/908ca0e684f3184075ef799128ee3f58f1e9db86/datafusion/physical-plan/src/aggregates/row_hash.rs#L347 and potentially do the actual refactor when working on a specific feature for SMJ. Regarding how to organize them into groups clearly, perhaps @comphead knows it better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
