Dandandan commented on PR #15423: URL: https://github.com/apache/datafusion/pull/15423#issuecomment-2763850029
> I'm working on HashAggregate [goldmedal#3](https://github.com/goldmedal/datafusion/pull/3) based on this PR. I found we shouldn't use only one config, `prefer_hash_selection_vector_partitioning`, to control whether to use the selection vector or not. For testing and benchmark convenience, it's better to split it into two configs, one for `hash join` and another for HashAggregate. Makes sense to me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
