Kontinuation commented on code in PR #1573:
URL: https://github.com/apache/datafusion-comet/pull/1573#discussion_r2019693023
##########
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##########
@@ -55,15 +55,48 @@ trait ShimCometScanExec {
protected def isNeededForSchema(sparkSchema: StructType): Boolean = false
protected def getPartitionedFile(f: FileStatusWithMetadata, p:
PartitionDirectory): PartitionedFile =
- PartitionedFileUtil.getPartitionedFile(f, f.getPath, p.values)
+ try {
+ PartitionedFileUtil.getPartitionedFile(f, f.getPath, p.values)
+ } catch {
+ case _: NoSuchMethodError =>
Review Comment:
I prefer maintaining compatibility with more Spark patch versions to
increase its adoptability. If it is known to not work with Spark <=3.5.4, we'd
better explicitly document it in [Supported Spark Versions](
https://datafusion.apache.org/comet/user-guide/installation.html#supported-spark-versions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
