comphead commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2017244901
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -490,8 +490,7 @@ object CometScanExec extends DataTypeSupport {
// TODO add map
dt match {
case s: StructType => s.fields.map(_.dataType).forall(isTypeSupported)
- // TODO: Add nested array and iceberg compat support
- // case a: ArrayType => isTypeSupported(a.elementType)
+ case a: ArrayType => isTypeSupported(a.elementType)
Review Comment:
shouldn't we support a ArrayType for CometScanExec as well as the structure
already supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
