alamb commented on code in PR #15411:
URL: https://github.com/apache/datafusion/pull/15411#discussion_r2012911157
##########
datafusion/datasource-csv/src/file_format.rs:
##########
@@ -642,6 +643,38 @@ impl BatchSerializer for CsvSerializer {
drop(writer);
Ok(Bytes::from(buffer))
}
+
+ async fn deserialize(
Review Comment:
I wonder how this is related to
https://docs.rs/datafusion/latest/datafusion/physical_plan/insert/trait.DataSink.html
Specifically, DataSink already has some way to serialize batches -- do we
need another one?
What is the usecase of this code as it isn't used to implement any built in
DataFusion features? Maybe we could add an example or something that shows how
it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
