mvzink commented on code in PR #1772:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1772#discussion_r2007913601
##########
src/parser/mod.rs:
##########
@@ -11299,41 +11304,26 @@ impl<'a> Parser<'a> {
}
if self.dialect.supports_comma_separated_set_assignments() {
+ if scope != ContextModifier::None {
+ self.prev_token();
+ }
+
if let Some(assignments) = self
.maybe_parse(|parser|
parser.parse_comma_separated(Parser::parse_set_assignment))?
{
return if assignments.len() > 1 {
- let assignments = assignments
- .into_iter()
- .map(|(var, val)| match var {
- OneOrManyWithParens::One(v) => Ok(SetAssignment {
- name: v,
- value: val,
- }),
- OneOrManyWithParens::Many(_) => {
- self.expected("List of single identifiers",
self.peek_token())
- }
- })
- .collect::<Result<_, _>>()?;
-
Ok(Set::MultipleAssignments { assignments }.into())
} else {
- let (vars, values): (Vec<_>, Vec<_>) =
assignments.into_iter().unzip();
-
- let variable = match vars.into_iter().next() {
- Some(OneOrManyWithParens::One(v)) => Ok(v),
- Some(OneOrManyWithParens::Many(_)) => self.expected(
- "Single assignment or list of assignments",
- self.peek_token(),
- ),
- None => self.expected("At least one identifier",
self.peek_token()),
- }?;
+ let SetAssignment { scope, name, value } =
+ assignments.into_iter().next().ok_or_else(|| {
+ ParserError::ParserError("Expected at least one
assignment".to_string())
+ })?;
Ok(Set::SingleAssignment {
- scope: Self::keyword_to_modifier(modifier),
- hivevar: modifier == Some(Keyword::HIVEVAR),
- variable,
- values,
+ scope,
+ hivevar,
+ variable: name,
+ values: vec![value],
Review Comment:
So I might be misunderstanding something, but I thought the reason this was
a vec was to support some kind of `SET var = a, b, c` syntax, but I don't see
that tested anywhere and don't remember where I saw it mentioned. If that
syntax doesn't actually exist, could `SingleAssignment` be reworked to contain
a `SetAssignment` or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
