jayzhan211 commented on code in PR #15230:
URL: https://github.com/apache/datafusion/pull/15230#discussion_r1995600861
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -342,13 +343,28 @@ impl DataFrame {
/// # Ok(())
/// # }
/// ```
- pub fn select(self, expr_list: Vec<Expr>) -> Result<DataFrame> {
- let window_func_exprs = find_window_exprs(&expr_list);
+ pub fn select(
+ self,
+ expr_list: impl IntoIterator<Item = impl Into<SelectExpr>>,
+ ) -> Result<DataFrame> {
+ let expr_list: Vec<SelectExpr> =
+ expr_list.into_iter().map(|e| e.into()).collect::<Vec<_>>();
+
+ let expressions = expr_list
+ .iter()
+ .filter_map(|e| match e {
+ SelectExpr::Expression(expr) => Some(expr.clone()),
+ _ => None,
+ })
+ .collect::<Vec<_>>();
+
+ let window_func_exprs = find_window_exprs(&expressions);
Review Comment:
it matches Expr::Window
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
