alamb opened a new issue, #15158:
URL: https://github.com/apache/datafusion/issues/15158

   ### Is your feature request related to a problem or challenge?
   
   - In this PR, @XiangpengHao  found that we couldn't compile datafusion with 
parquet support to wasm: https://github.com/apache/datafusion/pull/15102
   
   We do have a very nice `wasmtest` test to make sure datafusion is buildable 
with wasmpack (thanks @jonmmease !):
   
   
https://github.com/apache/datafusion/blob/04d823b852a6b3b8dd2e5b11491f0012e41b8d7e/.github/workflows/rust.yml#L251-L266
   
   However, As discussed here, that test doesn't use parquet and thus we broke 
parquet compilation
   - https://github.com/apache/datafusion/pull/15102#discussion_r1986318574
   
   @XiangpengHao  added the feature flag to the build in 
https://github.com/apache/datafusion/pull/1510 but wasmtest doesn't actually do 
anythign with parquet. So the flag could be removed accidentally in the future 
and all tests would still pass
   
   ### Describe the solution you'd like
   
   I would like to extend the `wasmtest` binary to actually something with 
parquet via wasm (not just adding the feature flag as in this PR)
   
   Perhaps it could just open a parquet file, or try writing one into memory
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to