findepi commented on code in PR #15110:
URL: https://github.com/apache/datafusion/pull/15110#discussion_r1988740063
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1758,7 +1758,7 @@ impl<S: SimplifyInfo> TreeNodeRewriter for Simplifier<'_,
S> {
// try_cast/cast(expr as data_type) op literal
Expr::BinaryExpr(BinaryExpr { left, op, right })
if
is_cast_expr_and_support_unwrap_cast_in_comparison_for_binary(
- info, &left, &right,
+ info, &left, &right, op,
Review Comment:
add `op` between left and right args -- this helps understand the role of
the two `&Expr` args to the function
(or maybe even pass the whole `&BinaryExpr` into the function)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
