irenjj commented on code in PR #15100:
URL: https://github.com/apache/datafusion/pull/15100#discussion_r1986188763
##########
datafusion/physical-plan/src/limit.rs:
##########
@@ -109,8 +109,12 @@ impl DisplayAs for GlobalLimitExec {
)
}
DisplayFormatType::TreeRender => {
- // TODO: collect info
- write!(f, "")
+ writeln!(f, "skip={}", self.skip)?;
+ write!(
+ f,
+ "fetch={}",
Review Comment:
Thanks @zjregee for the efforts,Here are some of my suggestions:
I think limit=xxx is more reasonable, and if fetch is None, maybe we don't
need to print it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
