mbutrovich commented on code in PR #1485: URL: https://github.com/apache/datafusion-comet/pull/1485#discussion_r1985745025
########## spark/src/main/java/org/apache/spark/shuffle/comet/CometTestShuffleMemoryAllocator.java: ########## @@ -67,11 +68,10 @@ public final class CometTestShuffleMemoryAllocator extends CometShuffleMemoryAll private static final int OFFSET_BITS = 51; private static final long MASK_LONG_LOWER_51_BITS = 0x7FFFFFFFFFFFFL; - private static CometTestShuffleMemoryAllocator INSTANCE; Review Comment: The `isSparkTesting` variable in the other file made me glance at the unused warnings in the files I was touching, and this isn't used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
