Shreyaskr1409 commented on issue #14796: URL: https://github.com/apache/datafusion/issues/14796#issuecomment-2699785605
> Yes you totally right, we can use just `macro_rules` Ive double checked your original PR and I was mistakenly thought the `doc` attribute should have been applied on the object but in fact it is a crate level independent macros. so we do not need to use proc macros in this case I tried using macro_rules but it did not work. i was getting the following error `proc-macros crate types currently cannot export any items other than functions tagged with #[proc_macro]` I tried some workarounds with proc-macro but in those cases, it compiled correctly after a lot of refactoring, but the changes did not show up in the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
