alamb commented on code in PR #14992:
URL: https://github.com/apache/datafusion/pull/14992#discussion_r1978152597
##########
.github/actions/setup-builder/action.yaml:
##########
@@ -36,9 +35,9 @@ runs:
# rustfmt is needed for the substrait build script
run: |
RETRY=("ci/scripts/retry" timeout 120)
- echo "Installing ${{ inputs.rust-version }}"
- "${RETRY[@]}" rustup toolchain install ${{ inputs.rust-version }}
- "${RETRY[@]}" rustup default ${{ inputs.rust-version }}
+ echo "Installing Rust ..."
+ # install toolchain specified by rust-toolchain.toml
+ "${RETRY[@]}" rustup toolchain install
Review Comment:
now this installs the version of rust specified by `rust-toolchain.toml`
##########
.github/actions/setup-builder/action.yaml:
##########
@@ -17,14 +17,13 @@
name: Prepare Rust Builder
description: 'Prepare Rust Build Environment'
-inputs:
- rust-version:
- description: 'version of rust to install (e.g. stable)'
- required: true
- default: 'stable'
runs:
using: "composite"
steps:
+ - uses: actions/checkout@v4
Review Comment:
We need to checkout the code in the builder setup to get the
`rust-toolchain.toml` file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
