mvzink commented on code in PR #1751:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1751#discussion_r1975782813
##########
tests/sqlparser_mysql.rs:
##########
@@ -1047,6 +1047,174 @@ fn parse_create_table_gencol() {
mysql_and_generic().verified_stmt("CREATE TABLE t1 (a INT, b INT AS (a *
2) STORED)");
}
+#[test]
+fn parse_create_table_without_equals() {
+ mysql_and_generic().one_statement_parses_to(
+ "CREATE TABLE foo (id INT) CHARSET utf8mb4",
+ "CREATE TABLE foo (id INT) DEFAULT CHARSET = utf8mb4",
+ );
+
+ mysql_and_generic().one_statement_parses_to(
+ "CREATE TABLE foo (id INT) COLLATE utf8mb4_unicode_ci",
+ "CREATE TABLE foo (id INT) COLLATE = utf8mb4_unicode_ci",
Review Comment:
Well, I think ideally these options would all be in a vector similar to
`Vec<SqlOption>`, but with a flag for the equals sign like I added for
`ALGORITHM` and `AUTO_INCREMENT`, which would avoid these mismatches. Maybe I
will see how #1747 shakes out and then revisit this, and mark this draft in the
meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
