crepererum commented on code in PR #14904:
URL: https://github.com/apache/datafusion/pull/14904#discussion_r1973262095
##########
datafusion/physical-plan/src/joins/stream_join_utils.rs:
##########
@@ -155,7 +156,10 @@ impl PruningJoinHashMap {
/// # Returns
/// The size of the hash map in bytes.
pub(crate) fn size(&self) -> usize {
- self.map.allocation_info().1.size() + self.next.capacity() *
size_of::<u64>()
+ let fixed_size = size_of::<PruningJoinHashMap>();
+
+ estimate_memory_size::<(u64, u64)>(self.map.capacity(),
fixed_size).unwrap()
Review Comment:
maybe put a TODO here: once we updated the the latest hashbrown version, you
no longer need to estimate this, see
https://docs.rs/hashbrown/latest/hashbrown/struct.HashTable.html#method.allocation_size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
