lovasoa commented on PR #1750:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1750#issuecomment-2687389699
Maybe we can add a small migration guide to minimize the impact of the
`Expr::Value` change. I suggest:
## Migrating usages of `Expr::Value`
Since v0.55, sqlparser the `Expr::Value` enum variant contains a
`ValueWithSpan` instead of a `Value`. Here is how to migrate.
### When pattern matching
```diff
- Expr::Value(Value::SingleQuotedString(my_string)) => { ... }
+ Expr::Value(ValueWithSpan{ value: Value::SingleQuotedString(my_string),
span: _ }) => { ... }
```
### When creating an `Expr`
Use the new `Expr::value` method (notice the lowercase v), which will create
a `ValueWithSpan` containing an empty span :
```diff
- Expr::Value(Value::SingleQuotedString(my_string))
+ Expr::value(Value::SingleQuotedString(my_string))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
