alamb opened a new issue, #14906: URL: https://github.com/apache/datafusion/issues/14906
### Is your feature request related to a problem or challenge? Thanks to some great work from @Omega359 as part of each commit to main DataFusion runs many thousand queries from the sqlite test suite ❤ This is documented here: https://github.com/apache/datafusion/blob/d47f7fb00f8ce175885ce6a59b8361f4ef8a93e1/datafusion/sqllogictest/README.md?plain=1#L218-L252 When expected output changes (for example, error messages) we currently use a script https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/regenerate_sqlite_files.sh that: 1. It relies on a fork of sqlogictest 2. It relies on a modified driver program This is problematic because 1. As the code in datafusion is updated (for example to new sqlogictest versions) the modified driver program may not work with the new sqlogictest version 2. The modified driver program may not work with new versions of sqllogictest This happened with https://github.com/apache/datafusion/pull/14824 ### Describe the solution you'd like @Omega359 says: > That is exactly what I was thinking and hopefully will fix tonight. I think a decent short-term fix is to 'lock' the sqllogictest-rs dependency version and add a comment that any update to it will require a full run of the regenerate script before committing. > > Long term ideally would be to improve my changes to my fork of sqllogictest-rs such that they would be suitable to submit a PR to that project. That is not an insignificant amount of work to be honest and I'm a bit thin on time for the next month or two. ### Describe alternatives you've considered _No response_ ### Additional context See last time we had to update the scripts based on changes: - https://github.com/apache/datafusion/pull/14901 - https://github.com/apache/datafusion/pull/14824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
