alamb commented on code in PR #14824:
URL: https://github.com/apache/datafusion/pull/14824#discussion_r1971470732
##########
datafusion/expr/src/expr_rewriter/mod.rs:
##########
@@ -286,6 +286,7 @@ pub struct NamePreserver {
/// If the qualified name of an expression is remembered, it will be preserved
/// when rewriting the expression
+#[derive(Debug)]
Review Comment:
💯
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -2455,7 +2455,7 @@ async fn test_count_wildcard_on_sort() -> Result<()> {
let ctx = create_join_context()?;
let sql_results = ctx
- .sql("select b,count(*) from t1 group by b order by count(*)")
+ .sql("select b,count(1) from t1 group by b order by count(1)")
Review Comment:
I had to double check -- the reason this needs to change is that the test is
comparing again a dataframe built with `count_all()` which now uses `count(1)`
Though maybe we could change `count_all()` to return `count(1) as
"count(*)"` so it would be consistent with older versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
