joroKr21 opened a new pull request, #14888:
URL: https://github.com/apache/datafusion/pull/14888
Whenever we use `recompute_schema` or `with_exprs_and_inputs`, this ensures
that we obtain the same schema.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Followup to #14734
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
In #14734 we introduced more aggressive constant folding which applies also
to aliases. That lead to the discovery that `SimplifyExpressions` doesn't
preserve the name of grouping sets which are relevant for the computed schema.
Note that this could be an issue also before #14734 because the grouping set
might have no alias and then if the expression were changed by constant
folding, it would still affect the result schema.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
In `SimplifyExpressions` we check for grouping sets and then map over their
children with the `NamePreserver`.
Otherwise, same as before.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Added a unit test.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No user facing changes, the schema of grouping sets should be more stable
after optimizations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
