berkaysynnada commented on code in PR #14813:
URL: https://github.com/apache/datafusion/pull/14813#discussion_r1966830680
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -498,6 +697,15 @@ pub fn get_window_mode(
None
}
+fn all_possible_sort_options(expr: Arc<dyn PhysicalExpr>) ->
Vec<PhysicalSortExpr> {
Review Comment:
This can be init once maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
