wiedld commented on code in PR #14821:
URL: https://github.com/apache/datafusion/pull/14821#discussion_r1966451622
##########
datafusion/physical-optimizer/src/enforce_sorting/sort_pushdown.rs:
##########
@@ -72,16 +70,18 @@ pub fn assign_initial_requirements(node: &mut SortPushDown)
{
}
pub fn pushdown_sorts(sort_pushdown: SortPushDown) -> Result<SortPushDown> {
- let mut new_node = pushdown_sorts_helper(sort_pushdown)?;
- while new_node.tnr == TreeNodeRecursion::Stop {
- new_node = pushdown_sorts_helper(new_node.data)?;
+ sort_pushdown
+ .transform_down(pushdown_sorts_helper)
+ .map(|transformed| transformed.data)
+}
+
+fn min_fetch(f1: Option<usize>, f2: Option<usize>) -> Option<usize> {
+ match (f1, f2) {
+ (Some(f1), Some(f2)) => Some(f1.min(f2)),
+ (Some(_), _) => f1,
+ (_, Some(_)) => f2,
+ _ => None,
Review Comment:
I'm being (overly) explicit here on purpose. I can make it more compact if
requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
