zjregee commented on PR #14812: URL: https://github.com/apache/datafusion/pull/14812#issuecomment-2674530942
Hi, @jayzhan211. I encountered some problems when trying to discard `TypeSignature::String`. After a simple direct replacement, the original test failed. The specific test failure items are shown in this https://github.com/apache/datafusion/actions/runs/13457031878/job/37603204917?pr=14812. I think the problem may be caused by the need to modify the logic of this part of the code in this function https://github.com/zjregee/datafusion/blob/replace-type-signature/datafusion/expr/src/type_coercion/functions.rs#L603-L636, but I am not sure, and hope to get some help and suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
