AdamGS opened a new issue, #14797: URL: https://github.com/apache/datafusion/issues/14797
Seems like somewhere in the shuffle of #14224, `FileSource::create_file_opener` got a `Result` argument which isn't very idiomatic IMO, especially as it doesn't seem like there's any special handling of it anywhere. Another small point here is that the function itself returns a `Result` that doesn't seem to actually propagate any error, but I can imagine that some `FileSource` implementation in the future would like the ability to do that. I have a [Vortex PR](https://github.com/spiraldb/vortex/pull/2417) that attempts to track the datafusion upstream and experiment with the new APIs, and while we do error there I think making those errors into panics or validating those invariants somewhere else would also make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
