Omega359 commented on code in PR #14684:
URL: https://github.com/apache/datafusion/pull/14684#discussion_r1962128561
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1617,9 +1617,19 @@ async fn with_column_renamed() -> Result<()> {
// accepts table qualifier
.with_column_renamed("aggregate_test_100.c2", "two")?
// no-op for missing column
- .with_column_renamed("c4", "boom")?
- .collect()
- .await?;
+ .with_column_renamed("c4", "boom")?;
+
+ assert_eq!("\
+ Projection: aggregate_test_100.c1 AS one, aggregate_test_100.c2 AS
two, aggregate_test_100.c3, aggregate_test_100.c2 + aggregate_test_100.c3 AS
sum AS total\
Review Comment:
I just worry that another column referenced 'sum' and then it is aliased to
'total' and what the behaviour of that would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
