zjregee commented on code in PR #14722:
URL: https://github.com/apache/datafusion/pull/14722#discussion_r1959024013
##########
datafusion/functions/benches/concat.rs:
##########
@@ -39,8 +40,15 @@ fn criterion_benchmark(c: &mut Criterion) {
let mut group = c.benchmark_group("concat function");
group.bench_function(BenchmarkId::new("concat", size), |b| {
b.iter(|| {
- // TODO use invoke_with_args
- criterion::black_box(concat().invoke_batch(&args,
size).unwrap())
+ criterion::black_box(
+ concat()
+ .invoke_with_args(ScalarFunctionArgs {
+ args: args.clone(),
Review Comment:
Thanks for your suggestion, I have optimized this in the submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
