ctsk opened a new pull request, #14733:
URL: https://github.com/apache/datafusion/pull/14733

   When reading through aggregation code, I saw that the `extract_ok!` macro 
seems to do the same thing as the `?` operator in this context.
   
   ```rust
   /// Extracts a successful Ok(_) or returns Poll::Ready(Some(Err(e))) with 
errors
   macro_rules! extract_ok {
       ($RES: expr) => {{
           match $RES {
               Ok(v) => v,
               Err(e) => return Poll::Ready(Some(Err(e))),
           }
       }};
   }
   ```
   
   I've replaced the usages of `extract_ok` with `?` in this PR and removed the 
macro.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to