goldmedal commented on code in PR #14725:
URL: https://github.com/apache/datafusion/pull/14725#discussion_r1958468118
##########
datafusion/functions/src/core/coalesce.rs:
##########
@@ -93,11 +95,8 @@ impl ScalarUDFImpl for CoalesceFunc {
}
/// coalesce evaluates to the first value which is not NULL
- fn invoke_batch(
- &self,
- args: &[ColumnarValue],
- _number_rows: usize,
- ) -> Result<ColumnarValue> {
+ fn invoke_with_args(&self, args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
+ let args = args.args;
Review Comment:
minor: It could use `take_function_args`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
