crepererum commented on issue #13631: URL: https://github.com/apache/datafusion/issues/13631#issuecomment-2663524272
# Test Report ## Steps See <https://blog.rust-lang.org/2024/11/27/Rust-2024-public-testing.html>. ### 1. Install the most recent nightly with `rustup update nightly`. No Problem. ### 2. In your project, run `cargo +nightly fix --edition`. Same as https://github.com/apache/datafusion/issues/13631#issuecomment-2659449432 , but I don't think these warnings are actually a problem for us. I doubt that most people really pay attention to the drop order in these scenarios anyways. ### 3. Edit `Cargo.toml` and change the edition field to say `edition = "2024"` and, if you have a `rust-version` specified, set `rust-version = "1.85"`. Done. ### 4. Run `cargo +nightly check` to verify your project now works in the new edition. Had to fix: ```text error: unnecessary qualification --> datafusion/core/src/execution/context/mod.rs:661:54 | 661 | ... as std::pin::Pin<Box<dyn futures::Future<Output = _> + Send>>) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: requested on the command line with `-D unused-qualifications` help: remove the unnecessary path segments | 661 - as std::pin::Pin<Box<dyn futures::Future<Output = _> + Send>>) 661 + as std::pin::Pin<Box<dyn Future<Output = _> + Send>>) | error: could not compile `datafusion` (lib) due to 1 previous error ``` ### 5. Run some tests, and try out the new features! Ran `cargo +nightly test --all-targets --workspace`. Found the following failures: ```text thread 'main' panicked at datafusion/core/benches/map_query_sql.rs:86:18: called `Result::unwrap()` on an `Err` value: Execution("map key must be unique, duplicate key found: 3889") note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace error: test failed, to rerun pass `-p datafusion --bench map_query_sql` ``` (also exists on `main`) ```text thread 'main' panicked at datafusion/functions/benches/cot.rs:38:64: called `Result::unwrap()` on an `Err` value: NotImplemented("Function cot does not implement invoke but called") note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace error: test failed, to rerun pass `-p datafusion-functions --bench cot` ``` (also exists on `main`) ```text thread 'main' panicked at datafusion/functions/benches/isnan.rs:37:63: called `Result::unwrap()` on an `Err` value: NotImplemented("Function isnan does not implement invoke but called") note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace error: test failed, to rerun pass `-p datafusion-functions --bench isnan` ``` (also exists on `main`) This is where I stopped. It's annoying that our tests don't run with the default feature set. I don't have the time to fix that. Overall though things compile and I expect the edition to not really regress things. ## Summary Once our MSRV reaches 1.85, I think we're good to go 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
