wiedld commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1957033990
##########
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##########
@@ -151,10 +165,51 @@ fn update_coalesce_ctx_children(
};
}
-/// The boolean flag `repartition_sorts` defined in the config indicates
-/// whether we elect to transform [`CoalescePartitionsExec`] + [`SortExec`]
cascades
-/// into [`SortExec`] + [`SortPreservingMergeExec`] cascades, which enables us
to
-/// perform sorting in parallel.
+/// If `repartition_sorts` is enabled,
Review Comment:
~I need to fix up these docs more than this, since the flowcharts refer to
the `parallelize_sorts` part of EnforceSorting, and not to everything that this
optimization pass does.~ Done. @alamb you may want to take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
