alamb opened a new pull request, #14655:
URL: https://github.com/apache/datafusion/pull/14655

   ## Which issue does this PR close?
   
   - closes https://github.com/apache/datafusion/issues/14479
   
   
   
   ## Rationale for this change
   
   Currently DataFusion's CI runs with whatever the most recent release is.  
This ensures DataFusion always works with the latest rust release but causes 
some non trival churn:
   
   ### Magically broken Releases
   Currently whenever a new rust version is released we often scramble to fix 
the CI (for new clippy lints for example).
   
   Some recent examples
   - https://github.com/apache/datafusion/pull/14065
   - https://github.com/apache/datafusion/pull/13596
   - https://github.com/apache/datafusion/pull/11654
   
   ### Old releases don't pass CI cleanly
   As @findepi  observes on https://github.com/apache/datafusion/issues/14479, 
always using the most recent Rust release means that older releases no longer 
cleanly pass CI tests
   
   
   
   ## What changes are included in this PR?
   We can solve this by specifying a specific version of Rust using 
`rust-toolchain.toml`
   https://rust-lang.github.io/rustup/overrides.html
   
   We use this in influxdb_iox and it works well for avoiding surprise brekages
   
   The downside is that to use a newer version of rust with DataFusion will 
require a PR to update the config file
   
   Changes:
   1. Add a `rust-toolchain.toml` file
   2. Add instructions on how to update it
   
   
   ## Are these changes tested?
   by CI
   (testing)
   
   
   ## Are there any user-facing changes?
   Hopefully a more controlled experience


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to