jkosh44 commented on issue #14633: URL: https://github.com/apache/datafusion/issues/14633#issuecomment-2656871273
> > > So as a workaround we could use any dialect that supports it (e.g. postgresql), gotcha. > > > > > > That sounds like it should work. From some googling it looks like the `FILTER` clause was added in the 2003 SQL standard, so it sounds reasonable to enable it for the `GenericDialect`. However, that might be a backwards incompatible change and I'm not sure how those decisions are made for this project. > > I think supporting a new feature should not have backwards compatibility issue, unlike disabling an existing feature FWIW, some queries that used to work could start failing due to how `FILTER` is interpreted. For example, currently with the `GenericDialect` the following query works fine: ```SQL CREATE TABLE t (a int); SELECT FILTER FROM (SELECT SUM(a) FILTER FROM t); ```` because `FILTER` is treated as an alias. However, with the `PostgresDialect` that query fails with the following error: `Schema error: No field named filter. Valid fields are "sum(t.a)".`, because `FILTER` is treated as a keyword. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
