wugeer commented on code in PR #1653:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1653#discussion_r1954510319
##########
src/ast/query.rs:
##########
@@ -2537,6 +2542,19 @@ impl fmt::Display for GroupByWithModifier {
GroupByWithModifier::Rollup => write!(f, "WITH ROLLUP"),
GroupByWithModifier::Cube => write!(f, "WITH CUBE"),
GroupByWithModifier::Totals => write!(f, "WITH TOTALS"),
+ GroupByWithModifier::GroupingSets(expr) => match expr {
+ Expr::GroupingSets(sets) => {
+ write!(f, "GROUPING SETS (")?;
+ let mut sep = "";
+ for set in sets {
+ write!(f, "{sep}")?;
+ sep = ", ";
+ write!(f, "({})", display_comma_separated(set))?;
+ }
+ write!(f, ")")
+ }
+ _ => unreachable!(),
Review Comment:
Good idea! Have Done. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
