milenkovicm commented on issue #1164: URL: https://github.com/apache/datafusion-ballista/issues/1164#issuecomment-2653893307
hey @alamb sorry to bother you again, I put some effort into implementing INSERT INTO, implementation is close to option 1, `Replace TableReference with actual table in the LogicalPlan::DML`. Now I have approach where I created my own logical extension node in ballista where I serialise TableSource as demonstrate in #1177 also I also implemented that in datafusion LogicalPlan::DML, adding table source reference, more details at https://github.com/apache/datafusion/commit/02db5e56d8bda26c890265bb047d2591f05641b6 where I believe it should go in the first place. Now I see it as a bit of "hacked" approach, but I don't see any better way to do it. Any advice would be appreciated, thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
