kazuyukitanimura commented on code in PR #1386:
URL: https://github.com/apache/datafusion-comet/pull/1386#discussion_r1951334244
##########
native/core/src/execution/jni_api.rs:
##########
@@ -319,6 +320,7 @@ fn parse_memory_pool_config(
"greedy_global" =>
MemoryPoolConfig::new(MemoryPoolType::GreedyGlobal, pool_size),
"fair_spill" => MemoryPoolConfig::new(MemoryPoolType::FairSpill,
pool_size_per_task),
"greedy" => MemoryPoolConfig::new(MemoryPoolType::Greedy,
pool_size_per_task),
+ "unbounded" => MemoryPoolConfig::new(MemoryPoolType::Unbounded, 0),
Review Comment:
I found the unbounded memory pool is useful for the cases we do not want to
allow any spilling and rather choose to fail the job. Spilling slows down the
job a lot and the unbounded memory pool is one way to measure the best case
without adjusting how much memory we provide for native exec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
